Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/df 101 debug budget display for render #24

Merged
merged 8 commits into from
Feb 24, 2024

Conversation

chisPmama
Copy link
Contributor

@chisPmama chisPmama commented Feb 24, 2024

Keypoints:

  • SetAmount default for Expense is set similarly to Income so users do not have to remove 0 first before adding new amount
  • New CSS added to reflect if the user's expenses have exceeded the budget, it will turn red
    image
  • Colors were changed on Piechart to reflect the labels correctly
  • Rendered data adjusted to be titleized and light logic to place in USD and correct percentage displays

Related Issue(s)

closes df-101

Checklist:

  • New/Modified Tests are Passing
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings or errors.

Additional Notes:

Copy link

linear bot commented Feb 24, 2024

Copy link

vercel bot commented Feb 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dough-fin-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2024 7:20am

@chisPmama chisPmama marked this pull request as ready for review February 24, 2024 06:34
@shawndcarpenter
Copy link
Contributor

I checked this out locally and it was all functional and looks great! I'm a big fan of extra color-coding. Also looked over your code, but can't give too much of a response on that due to a limited knowledge of JavaScript. Appreciate the commenting though, it helped me a bit!

@shawndcarpenter shawndcarpenter merged commit 7a15da9 into main Feb 24, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants