projects/01drv_ism330: Fix ISM330 crashing because the IMU is configured too soon after boot #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaidAlvarado
changed the title
aabadie
reviewed
Jun 5, 2024
projects/01drv_ism330/01drv_ism330.c
Outdated
| db_timer_hf_init(0); | ||
| db_timer_hf_delay_ms(0, 500); // Wait for the IMU to power-up |
There was a problem hiding this comment.
Why not do this straight at the beginning the db_ism330_init function? (That would also mean the driver library has a dependency on "timer_hf"). Also why not use the low frequency timer instead of the high frequency one?
There was a problem hiding this comment.
No reason, time_hf was already available in the example.
I'll add it inside the driver
aabadie
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #320