Securityparameters #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- parsing, using, testing
I'd rather not add another dependency, especially if it's just for one line, and I think the standard library handles this fine. I couldn't find a fixture for `mocker`, so tests failed locally for me - I replaced it with unittest's patch.
|
I pushed up a few changes to the tests; namely, I'd rather not add more dependencies that needed, and |
This is probably where `mocker` came from
Dorthu
approved these changes
Dec 19, 2021
|
mocker is the pytest fixture for unittest.mock - provided by pytest-mock. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #36 #18
tests #14