Skip to content

Commit

Permalink
2.0.1
Browse files Browse the repository at this point in the history
  • Loading branch information
Dorako committed Mar 7, 2023
1 parent e7e0742 commit 5950339
Show file tree
Hide file tree
Showing 10 changed files with 37 additions and 18 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
# 2.0.1

- (Fix) Fixed an issue where Dalvyn's CRB styled journals was applied regardless of setting
- (Fix) Fixed an issue where Module Management+'s export screen was illegible in dark theme
- (Fix) Fixed an issue where some text in the critical deck journal was illegible
- (Fix) Fixed an issue where dark theme support for Monk's Enhanced Journals was not working right, by blacklisting MEJ from dark theme until I have the energy to debug it again

# 2.0.0

- (New) Added screenshots to the github page; updated the FVTT module page description.
Expand Down
2 changes: 1 addition & 1 deletion modules/base-theme-hooks.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ for (const appName of ["JournalSheet", "JournalPageSheet"]) {
//"JournalPageSheet"
Hooks.on("render" + appName, (app, html, data) => {
if (html[0].id.includes("JournalSheetPF2e-Compendium-pf2e-criticaldeck")) return;
html.closest(".app").find(".journal-entry-content").addClass("dorako-ui dalvyn-journal");
// html.closest(".app").find(".journal-entry-content").addClass("dorako-ui dalvyn-journal");
const isDarkJournals = game.settings.get("pf2e-dorako-ui", "theme.enable-dark-theme-journals");
if (!isDarkJournals) {
html.closest(".app").find(".journal-entry-content").addClass("dorako-ui light-theme");
Expand Down
29 changes: 15 additions & 14 deletions modules/dark-theme-hooks.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,20 +74,21 @@ Hooks.on("renderJournalTextPageSheet", (app, html, data) => {
frameHtml.closest(".app").find(".journal-entry-content").addClass("dorako-ui dark-theme");
});

Hooks.on("renderEnhancedJournal", (app, html, data) => {
const theme = game.settings.get("pf2e-dorako-ui", "theme.application-theme");
if (theme === "no-theme") return;
html[0].classList.add(theme);
const isDarkJournals = game.settings.get("pf2e-dorako-ui", "theme.enable-dark-theme-journals");
if (!isDarkJournals) {
html.closest(".app").find(".journal-entry-content").addClass("dorako-ui light-theme");
return;
}
html.closest(".app").find(".journal-entry-content").addClass(`dorako-ui dark-theme`);
// ^ seems like this doesn't work, perhaps fires before the data exists.
// html.closest(".app").find(".journal-page-content").addClass(`dorako-ui dark-theme`);
// ^ seems like this doesn't work, perhaps fires before the data exists.
});
// MEJ dark theme not quite right yet
// Hooks.on("renderEnhancedJournal", (app, html, data) => {
// const theme = game.settings.get("pf2e-dorako-ui", "theme.application-theme");
// if (theme === "no-theme") return;
// html[0].classList.add(theme);
// const isDarkJournals = game.settings.get("pf2e-dorako-ui", "theme.enable-dark-theme-journals");
// if (!isDarkJournals) {
// html.closest(".app").find(".journal-entry-content").addClass("dorako-ui light-theme");
// return;
// }
// html.closest(".app").find(".journal-entry-content").addClass(`dorako-ui dark-theme`);
// // ^ seems like this doesn't work, perhaps fires before the data exists.
// // html.closest(".app").find(".journal-page-content").addClass(`dorako-ui dark-theme`);
// // ^ seems like this doesn't work, perhaps fires before the data exists.
// });

// for (const appName of ["JournalSheet"]) {
// // "JournalPageSheet"
Expand Down
2 changes: 2 additions & 0 deletions sass/foundry/_application-dark.scss
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,8 @@
color: var(--color-text-light-highlight);
}

.journal-entry-page .journal-page-content .fumble-deck code,
.journal-entry-page .journal-page-content .fumble-deck h1,
.journal-entry-page .journal-page-content .critical-deck h1,
.journal-entry-page .journal-page-content .critical-deck code {
color: black;
Expand Down
2 changes: 1 addition & 1 deletion sass/module/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
@import "cautious-gamemasters-pack", "combat-carousel", "custom-hotbar", "damage-log", "dfce", "dice-tray", "dorako-ui",
"enhancen-terrain-layer", "filepicker-plus", "koboldworks-turn-announcer", "macros", "monarch", "monks", "polyglot",
"scene-preview", "speaking-as", "target-damage", "token-action-hud", "workbench", "party-overview", "pf2e-dailies",
"dalvyn-journal", "swade", "chat-reactions", "card-hand-mini-toolbar";
"dalvyn-journal", "swade", "chat-reactions", "card-hand-mini-toolbar", "module-management-plus";
3 changes: 3 additions & 0 deletions sass/module/_module-management-plus.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#module-credits-copy-export {
background: none !important;
}
2 changes: 2 additions & 0 deletions styles/dorako-ui.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion styles/dorako-ui.css.map

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions styles/module-support.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion styles/module-support.css.map

Large diffs are not rendered by default.

0 comments on commit 5950339

Please sign in to comment.