Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to use Cloudformation hosted Tranforms #297

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

shadycuz
Copy link
Member

@shadycuz shadycuz commented Dec 14, 2023

This commit adds the groundwork for using Cloudformation hosted Transforms. The Transforms add or enhance the existing Cloudformation functionality.

The only Transform currently supported is the AWS::LanguageExtensions and it is only partially implemented. This commit only adds support for using a DefaultValue when using the !FindInMap function.

Releated to #271

This commit adds the groundwork for using Cloudformation hosted
Transforms. The Transforms add or enhance the existing Cloudformation
functionality.

The only Transform currently supported is the AWS::LanguageExtensions,
and it is only partially implemented. This commit only adds support for
using a DefaultValue when using the !FindInMap function.
@shadycuz shadycuz added enhancement New feature or request minor A new feature has been added. labels Dec 14, 2023
@shadycuz shadycuz self-assigned this Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (c1e1246) 95.97% compared to head (f4862f5) 95.00%.
Report is 1 commits behind head on develop.

Files Patch % Lines
src/cloud_radar/cf/unit/functions.py 74.19% 4 Missing and 4 partials ⚠️
src/cloud_radar/cf/unit/_template.py 89.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #297      +/-   ##
===========================================
- Coverage    95.97%   95.00%   -0.98%     
===========================================
  Files           10       11       +1     
  Lines          695      760      +65     
  Branches       145      155      +10     
===========================================
+ Hits           667      722      +55     
- Misses          16       21       +5     
- Partials        12       17       +5     
Flag Coverage Δ
unit 95.00% <86.66%> (-0.98%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shadycuz shadycuz merged commit ee832a7 into develop Dec 18, 2023
7 checks passed
@shadycuz shadycuz deleted the add_transform_support branch December 18, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor A new feature has been added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant