Better logging and error handling when cloning terraform src code #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the terraform source code repo is not cloned correctly. When this happens the InvalidGitRepositoryError exception is raised. To fix it the user must delete the directory and try again but they did't know the path to the directory. This commit logs the path to the directory but also catches the exception and removes the directory and reclones it.
Codecov Report
@@ Coverage Diff @@
## develop #178 +/- ##
===========================================
+ Coverage 73.41% 75.37% +1.95%
===========================================
Files 16 16
Lines 1042 1076 +34
Branches 153 158 +5
===========================================
+ Hits 765 811 +46
+ Misses 237 229 -8
+ Partials 40 36 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29
Better late than never?