Minor tweak (use a set instead of a list as datasource.targets)

bidscoin/bids.py

@@ -53,7 +53,7 @@
 
 
 class DataSource:
-    def __init__(self, provenance: Union[str, Path]='', plugins: dict=None, dataformat: str='', datatype: str='', subprefix: str='', sesprefix: str='', targets: List[Path] = ()):
+    def __init__(self, provenance: Union[str, Path]='', plugins: dict=None, dataformat: str='', datatype: str='', subprefix: str='', sesprefix: str='', targets: set[Path] = ()):
         """
         A source data type (e.g. DICOM or PAR) that can be converted to BIDS by the plugins
 
@@ -76,7 +76,7 @@ def __init__(self, provenance: Union[str, Path]='', plugins: dict=None, dataform
             self.is_datasource()
         self.subprefix   = subprefix
         self.sesprefix   = sesprefix
-        self.targets     = list(targets)
+        self.targets     = set(targets)
         self._cache      = {}
 
     def resubprefix(self) -> str:
@@ -1987,7 +1987,7 @@ def rename_runless_to_run1(runs: List[dict], scans_table: pd.DataFrame) -> None:
 
                     # Change target from run-less to run-1
                     run['datasource'].targets.remove(target)
-                    run['datasource'].targets.append((outfolder/run1_bidsname).with_suffix(suffixes))
+                    run['datasource'].targets.add((outfolder/run1_bidsname).with_suffix(suffixes))
 
 
 def updatemetadata(datasource: DataSource, targetmeta: Path, usermeta: dict, extensions: list, sourcemeta: Path = Path()) -> dict:

bidscoin/plugins/dcm2niix2bids.py

@@ -314,7 +314,7 @@ def bidscoiner_plugin(session: Path, bidsmap: dict, bidsses: Path) -> Union[None
                 if not list(outfolder.glob(f"{bidsname}.*nii*")): continue
 
             jsonfiles.update(outfolder.glob(f"{bidsname}.json"))  # add existing created json files: bidsname.json
-            datasource.targets += outfolder.glob(f"{bidsname}.*[!json]")    # Add files created using this run-item (except sidecars)
+            datasource.targets.update(outfolder.glob(f"{bidsname}.*[!json]"))    # Add files created using this run-item (except sidecars)
 
             # Handle the ABCD GE pepolar sequence
             extrafile = list(outfolder.glob(f"{bidsname}a.nii*"))
@@ -428,7 +428,7 @@ def bidscoiner_plugin(session: Path, bidsmap: dict, bidsses: Path) -> Union[None
                 if newbidsfile.is_file():
                     LOGGER.warning(f"Overwriting existing {newbidsfile} file -- check your results carefully!")
                 dcm2niixfile.replace(newbidsfile)
-                datasource.targets.append(newbidsfile)
+                datasource.targets.add(newbidsfile)
 
                 # Rename all associated files (i.e. the json-, bval- and bvec-files)
                 oldjsonfile = dcm2niixfile.with_suffix('').with_suffix('.json')

bidscoin/plugins/nibabel2bids.py

@@ -232,7 +232,7 @@ def bidscoiner_plugin(session: Path, bidsmap: dict, bidsses: Path) -> None:
 
         # Save the sourcefile as a BIDS NIfTI file
         nib.save(nib.load(sourcefile), bidsfile)
-        datasource.targets.append(bidsfile)
+        datasource.targets.add(bidsfile)
 
         # Load / copy over the source meta-data
         sidecar  = bidsfile.with_suffix('').with_suffix('.json')

bidscoin/plugins/spec2nii2bids.py

@@ -259,7 +259,7 @@ def bidscoiner_plugin(session: Path, bidsmap: dict, bidsses: Path) -> Union[None
             if not list(outfolder.glob(f"{bidsname}.nii*")): continue
 
         # Add files created using this bidsmap run-item (except sidecars)
-        datasource.targets += outfolder.glob(f"{bidsname}.*[!json]")
+        datasource.targets.add(outfolder.glob(f"{bidsname}.*[!json]"))
 
         # Load / copy over and adapt the newly produced json sidecar-file (NB: assumes every NIfTI-file comes with a json-file)
         metadata = bids.updatemetadata(datasource, sidecar, run['meta'], options['meta'])

tests/test_bids.py

@@ -474,7 +474,7 @@ def test_rename_runless_to_run1(tmp_path):
             outfile = (outfolder/file_name).with_suffix(suffix)
             outfile.touch()
             if suffix == '.nii.gz':
-                run['datasource'].targets.append(outfile)
+                run['datasource'].targets.add(outfile)
                 matched_runs.append(run)
 
     # Create the scans table