Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustable thrust vectoring for engine parts #1807

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BlazeWolf1122
Copy link
Contributor

big thanks to conman for helping me fix up my jank ass code cause he knows java and i dont
Adjustable thrust vectoring value for engine parts, as thrust changes to mts physics system with thrust vectoring has proven to be a headache for me and other PAs, especially those from GAP. There are no LCs for defaulting the value to 1.0, as a majority of people who ive asked in mts were in favor of defaulting the value to 0 when thrust vectoring is not found. Also, this jet thrust vectoring is VMable Please let me know in MTS if theres any issues or code oversights.

Adjustable thrust vectoring value for engine parts, as thrust changes to mts physics system with thrust vectoring has proven to be a headache for me and other PAs, especially those from GAP.
There are no LCs for defaulting the value to 1.0, as a majority of people who ive asked in mts were in favor of defaulting the value to 0 when thrust vectoring is not found.
@BlazeWolf1122 BlazeWolf1122 changed the title Patch 1 Adjustable thrust vectoring for engine parts Jun 23, 2024
@@ -1305,7 +1311,7 @@ public double addToForceOutput(Point3D force, Point3D torque) {
engineForce.set(engineAxisVector).scale(thrust);
force.add(engineForce);
engineForce.reOrigin(vehicleOn.orientation);
torque.add(localOffset.crossProduct(engineForce));
torque.add(localOffset.crossProduct(engineForce).scale(currentThrustVectorMultiplier));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mentioned this There are no LCs for defaulting the value to 1.0, as a majority of people who ive asked in mts were in favor of defaulting the value to 0 when thrust vectoring is not found.

This means that torque will never be added by default, where it was before, since all engine torque will be scaled by 0, and multiplying anything by 0 makes it 0. Are folks SURE they want to remove thrust-torquing by default? This will result in jets with an engine out behaving differently than propeller craft with engines out, since propellers will apply torque but jets won't.

Copy link
Contributor

@conman180 conman180 Aug 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you wouldnt believe the storm of complaints about GAP right now due to engines being located away from model origin points. even though they shouldnt vector. the amount of torque being applied is huge in some cases leading to planes doing wheelies or stoppies just by throttling up and stationary

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well i think the problem may also due to mts doesnt take into account the moment generated by lift and gravity, the list and gravity force are lift force are apply at the same position, so if the engine are lower or higher than z0, the thrust vectoring will make the plane pull its nose up or down even at very speed, maybe we need a CG system?
4ead5f0f10cdc596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants