New Msg for widget and button to add new record #31309
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Oct 8, 2024
htdocs/core/boxes/modules_boxes.php
Outdated
| $out .= '<tr><td colspan="2" class="center"><span class="opacitymedium">'.$langs->trans("NoRecordFound").' </span>'; | ||
| if (!empty($this->depends)) { | ||
| if (count($this->depends) > 1) { | ||
| foreach ($this->depends as $key => $val) { |
There was a problem hiding this comment.
I don't understand why you use ->depends to define the link.
For example the module Order depends on Thirdparty but the "+" link must be to add a new order.
I suggest to introduce a new property
->urltoaddentry
into each widget
If ->urltoaddentry is defined into the widget file, we can show the "+" link, if not, we do nothing.
There was a problem hiding this comment.
yes i see this is much better
eldy
added
the
PR to fix or conflict to solve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW|New msg when no records found on widget and add button for create a new one