Fix const INVOICE_USE_RETAINED_WARRANTY #30533
Open
+4
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-Ngr
force-pushed
the
20.0_fix_INVOICE_USE_RETAINED_WARRANTY
branch
from
6d0e2dd
to
724c586
Compare
eldy
requested changes
Aug 10, 2024
htdocs/admin/invoice_situation.php
Outdated
| @@ -79,12 +79,13 @@ | |||
| $item->nameText = $langs->trans('AllowedInvoiceForRetainedWarranty'); | |||
|
|
|||
| $arrayAvailableType = array( | |||
| 0 => "", // don't use $showempty in selectArray since it sets a value of -1 | |||
There was a problem hiding this comment.
We must use showempty into select component when we want empty value. Empty value generates troubles depending on js code used to beautify the combi list (like select2).
So fix must be managed during or before the insert. For example if value is -1, no update should be done.
There was a problem hiding this comment.
I changed the PR to solve a related issue on display of chosen value (see initial message edit).
eldy
added
the
PR to fix or conflict to solve
thomas-Ngr
force-pushed
the
20.0_fix_INVOICE_USE_RETAINED_WARRANTY
branch
from
20e5558
to
3159eb8
Compare
thomas-Ngr
force-pushed
the
20.0_fix_INVOICE_USE_RETAINED_WARRANTY
branch
from
19f7f28
to
70e5dcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX setup of const INVOICE_USE_RETAINED_WARRANTY
When modifying conf for situation invoice (admin/invoice_situation.php), the const INVOICE_USE_RETAINED_WARRANTY is set to -1 when it is left empty.
This creates issues in DLB on code using getDolGlobalInt('INVOICE_USE_RETAINED_WARRANTY').
edit:
Another issue is the display of chosen value right after the update, as demonstrated in this gif :
This PR fixes both issues.