Feat: Searchable logs #757
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think, by mistake I pushed both pull requests to the same branch, hope you se the changes and think they are good for the project. |
Siumauricio
requested changes
Nov 24, 2024
Comment on lines
+128
to
+138
| <SelectContent> | ||
| <SelectItem value="50lines">50 lines</SelectItem> | ||
| <SelectItem value="150lines">150 lines</SelectItem> | ||
| <SelectItem value="500lines">500 lines</SelectItem> | ||
| <SelectItem value="1000lines">1000 lines</SelectItem> | ||
| <SelectSeparator className="my-2" /> | ||
| <SelectItem value="last10min">Last 10 min</SelectItem> | ||
| <SelectItem value="last30min">Last 30 min</SelectItem> | ||
| <SelectItem value="lasthour">Last hour</SelectItem> | ||
| <SelectItem value="last24h">Last 24h</SelectItem> | ||
| </SelectContent> |
There was a problem hiding this comment.
How did you deteremine the time of the logs? I don't see any logic applied to the logs itself in the backend? can you explain how the search and filters works?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searchable logs and better way to select visible logs
Hope this is something you want sir! 🫡