[feat-mindmap]: adds mindmap feature #12
Open
+1,736
−11,304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devesh-verma
requested changes
Nov 1, 2024
| ...createMindmapDto, | ||
| userId: id, | ||
| name, | ||
| path: 'temp' |
There was a problem hiding this comment.
@BULMA-OO lets get rid of this temp form everywhere and make use to actual path where the files will be stored.
| return this.mindmapService.create( | ||
| createMindmapDto, | ||
| request.user._id, | ||
| request.user.firstName, |
There was a problem hiding this comment.
@BULMA-OO why are we sending user's firstName in the name property of mindmap?
|
|
||
| async upload(mindmap: { name: string; content: string; path: string }) { | ||
| const mindmapPayload = { | ||
| name: mindmap?.name ?? new Types.ObjectId().toString(), |
There was a problem hiding this comment.
This name property refers to the doc._id of the mindmap doc. But instead you are sending user.name in this property from the create function of the controller.
Comment on lines
+34
to
40
| const doc: any = await this.repository.findById(id); | ||
| if (doc) { | ||
| // 2. fetch content from s3 | ||
| const key = doc.path; | ||
| const key = doc.path + '/' + doc._id; | ||
| const file = await this.fileService.getFile(key); | ||
| return file; | ||
| } |
There was a problem hiding this comment.
Suggested change
| const doc: any = await this.repository.findById(id); | |
| if (doc) { | |
| // 2. fetch content from s3 | |
| const key = doc.path; | |
| const key = doc.path + '/' + doc._id; | |
| const file = await this.fileService.getFile(key); | |
| return file; | |
| } | |
| const doc: Notes = await this.repository.findById(id); | |
| if (doc) { | |
| // 2. fetch content from s3 | |
| const key = doc.path + '/' + doc["_id"]; | |
| const file = await this.fileService.getFile(key); | |
| return file; | |
| } |
@BULMA-OO Why are you assigning any to doc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.