Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use version generated from parent version strategy if no version supplied #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jkeen
Copy link

@jkeen jkeen commented Jul 28, 2021

This addon states in its config that versioning should be done using versionStrategy in the parent ember-service-worker addon.

// Changing this version number will bust the cache, but you probably do not
// want to be doing this manually, but rather using `versionStrategy` as
// explained here http://ember-service-worker.com/documentation/configuration/#versioning
version: '1',

Unfortunately removing the version flag from the config block as implied just defaults the version to 1 and does not change the local version or bust the cache, despite the parent version number changing due to the versionStrategy. This PR pulls in the parent version number if the local version is not set.

@chbonser
Copy link

@martndemus mind taking a look at this PR and seeing if it makes sense to merge? There is a similar PR for the asset cache as well DockYard/ember-service-worker-asset-cache#46.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants