Skip to content

Commit

Permalink
Remove package-lock.json and update service teardown logic
Browse files Browse the repository at this point in the history
With combination of Ember.js v3.20 and ember-modifier v2
tests fail as modifier is torn down after the service.
  • Loading branch information
SergeAstapov committed Aug 5, 2020
1 parent 77667a4 commit 659a030
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 17,914 deletions.
2 changes: 2 additions & 0 deletions addon/services/in-viewport.js
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,11 @@ export default class InViewport extends Service {
set(this, 'registry', null);
if (this.observerAdmin) {
this.observerAdmin.destroy();
set(this, 'observerAdmin', null);
}
if (this.rafAdmin) {
this.rafAdmin.reset();
set(this, 'rafAdmin', null);
}
}

Expand Down
Loading

0 comments on commit 659a030

Please sign in to comment.