New functionality: Occurrence / Concurrence / Transferrence / Commemorations #3438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by so many recent issues (e.g., #3418, #3416, #3348, #3347, #3211, and #2970) regarding wrong commemorations (either wrong order, missing due to transferred feasts, or showing up transferred together with some other feasts) that required manual workarounds and multiple database files for one and the same feast dependent on the date of Easter, I reworked the
getrank()
andoratio()
routine, effectively replacing the former by two new functionsoccurrence()
andconcurrence()
. In addition, the following changes are contained within the package:if
-else
for the various rubrical structures. Please refer to the table built into technical.html for reference.[Rank]
hash of non Latin files after the first;;
. Thus, it is still possible to translate a Saints or Feasts name to a local language without the risk of assigning a deviating numerical rank or Common.01-11=01-11~01-11cc=S. Hilarius...
for instance. I have tried it privately and can use the method also to define Diocesan propers as wished for long time ago in Options for diocesan propers #423Nat26.txt
...Nat31.txt
in theTempora
folder supplementing the offices12-26.txt
...12-30.txt
as before. Comparing the Matins readings in the Divino Afflatu version with the books from 1888 and 1906, I noticed a difference in the Tridentine version which has not been addressed by the database yet. I hope to incorporate these changes in time before Christmas. I've seen discussions on that reaching as far back as Ninth lesson for commemoration of Sunday in the octave of Christmas missing #2125 and Dominica infra Octavam Nativitatis #1062 which have been addressed for the post DA version by Fix #1060 #1062 #2117.a.txt
...g.txt
for the common transfers by Dominical Letter. I have completed the files relevant for 2023 and 2024 to buy some time to finish the rest. The transfers of Scripture is a separate topic to be addressed at some point in the future.missa
folders to the best of my knowledge and understanding. I am sure their is open work to do which I have not noticed unfortunately.Laudetur Jesus Christus!