Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experiment] Use Template::Semantic to isolate logic #2436

Closed
wants to merge 4 commits into from

Conversation

malukenho
Copy link
Contributor

I need a review on it, as well as opinions on that. I know that we have an issue #626 from 2016. I'm not sure if that still applies.

Future refactors will be easier with grep/sed/ag/etc.

Signed-off-by: Jefersson Nathan <[email protected]>
Signed-off-by: Jefersson Nathan <[email protected]>
@malukenho
Copy link
Contributor Author

I'm not even sure what is the future plans for this project. Is there any place I can look into it?

@gregordick
Copy link
Contributor

Thanks for the PR. Templating is a good thing, but I think that the presentation, logic and database are so intertwined that retrofitting it is likely to be prohibitively difficult. Then again, I'd be glad to be proven wrong. Before we pull in another dependency, I think if we're to pursue a project of this sort, we should try to push the templating deeper and see which bits are difficult. If you're interested in looking into this, I'd be glad to review it.

As it happens, I've been working on an off for a few years on a proof-of-concept implementation of a Python package for generating offices from the DO datafiles, and I've just started on the templating in the past week or two (but haven't pushed anything yet). This is very much a side project and might never go anywhere, but I hope that it will provide a useful point of reference for discussions of possible future directions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants