Merge pull request #39 from ziggurad/feature/add-command-to-remove-in…

…-process-status-for-objects-fix Add command to remove related products in process flag - FIX
DivanteLtd · Feb 18, 2021 · fba1434 · fba1434
2 parents 6a31733 + 2f286c5
commit fba1434
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 7 deletions.
diff --git a/.github/workflows/analysis.yml b/.github/workflows/analysis.yml
@@ -1,5 +1,5 @@
 name: Analysis
-on: [push]
+on: [push, pull_request]
 
 jobs:
   build:

diff --git a/src/Command/FieldcollectionsUpdateCommand.php b/src/Command/FieldcollectionsUpdateCommand.php
@@ -25,8 +25,11 @@ class FieldcollectionsUpdateCommand extends Command
      * @param InstallerService $installerService
      * @param string|null $name
      */
-    public function __construct(PimcoreFieldcollectionLocator $locator, InstallerService $installerService, ?string $name = null)
-    {
+    public function __construct(
+        PimcoreFieldcollectionLocator $locator,
+        InstallerService $installerService,
+        ?string $name = null
+    ) {
         parent::__construct($name);
         $this->locator = $locator;
         $this->installerService = $installerService;
@@ -38,7 +41,9 @@ public function __construct(PimcoreFieldcollectionLocator $locator, InstallerSer
     protected function configure()
     {
         $this
-            ->setDescription('Updates fieldcollections from one (if specified) or all (by default) bundles under src catalog')
+            ->setDescription(
+                'Updates fieldcollections from one (if specified) or all (by default) bundles under src catalog'
+            )
             ->addArgument('bundle', InputArgument::OPTIONAL, 'Bundle name');
     }
 

diff --git a/src/FileLocator/PimcoreFieldcollectionLocator.php b/src/FileLocator/PimcoreFieldcollectionLocator.php
@@ -5,6 +5,6 @@
 
 class PimcoreFieldcollectionLocator extends PimcoreBundlesFilesLocator
 {
-    protected const SUBCATALOG = 'Resources/fieldcollections';
-    protected const FILE_REGEX = '/fieldcollection\_(\w*)\_export\.json/';
+    const SUBCATALOG = 'Resources/fieldcollections';
+    const FILE_REGEX = '/fieldcollection\_(\w*)\_export\.json/';
 }
diff --git a/src/Service/DomService.php b/src/Service/DomService.php
@@ -27,7 +27,7 @@ public function loadHTML(string $html): \DOMDocument
             $doc->removeChild($doc->firstChild);
         }
 
-        while ($container->firstChild ) {
+        while ($container->firstChild) {
             $doc->appendChild($container->firstChild);
         }