114 modificacion navbar #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontainer_page cambieel importa de NavBar. iconos: a varios iconos le quite el stroke-widht que estaba generando un error, cree iconos carShoping, hamburguerClose, hamburguerOpen, Login, en index de img assets agregue la imagen del logo sin letras para el navbar, agregue a assets img la imagen del carrito sin letras. iconText.tsx lo modifique para que los iconos no tengan un mismo tamaño, ahora el tamaño se lo damos con className cuando llamamos a iconText higth y width. pagination: elimino los strokes-width que generaban error, cambio value por placeholder que tambien generaba error. ThemeMode: le cambio el tamaño por defecto. Mainbutton: lo modifico para poder usar className. brandCard: elimino el background que no dejaba ver el texto del hover. LandingCard: elimino el border y agrego shadow. containerCardsBrands: modifico la cantidad de items por pagina. inputField: en lefticon le agrego un pading left. Paymethod: modifico el tamaño del icontext con el className.
…o del button defaul para usarlo en el nav que es transparente. inputField elimine el borde.
…rt useAuth. en navBar añadi Links a iconos.
claymartinez
requested review from
duvan29,
SourerDev,
CBarreraB and
Jonatan041101
duvan29
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anteriormente como estabamos un poco incomunicados y ausentes, estuve tocando varios archivos desde mi rama, corregi los conflictos con develop. Por lo que no afectara a develop.