Skip to content

Commit

Permalink
Get tidy.conf more automatically
Browse files Browse the repository at this point in the history
Simplify script and make it extract the version automatically.
Also clarify docs.
  • Loading branch information
windymilla authored and cpeel committed Nov 14, 2021
1 parent b1609d1 commit 0729c41
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,11 @@ any other changes before tagging and releasing a new binary.
If ebookmaker crashes and the traceback refers to imported packages, it
may be that one of the packages has been updated, requiring an updated
version of pyinstaller:
version of pyinstaller. Try upgrading to the latest version of PyInstaller
by finding the [latest released version](https://github.com/pyinstaller/pyinstaller/releases)
and upgrading to it with:
```
pipenv install "pyinstaller==4.7"
pipenv install "pyinstaller==$LATEST_RELEASE"
```
An error such as `local variable 'xxxx' referenced before assignment` may
Expand Down
8 changes: 2 additions & 6 deletions get_tidy_conf.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@

set -e

VERSION=0.11.26
VERSION=$(grep ebookmaker Pipfile | tr -d '"' | sed 's/.*==//')

rm -rf ebookmaker.zip ebmtemp
curl -L -o ebookmaker.zip https://github.com/gutenbergtools/ebookmaker/archive/refs/tags/$VERSION.zip
unzip -q ebookmaker.zip -d ebmtemp
cp ebmtemp/ebookmaker-$VERSION/ebookmaker/parsers/tidy.conf dist
rm -rf ebookmaker.zip ebmtemp
curl -L -o dist/tidy.conf https://github.com/gutenbergtools/ebookmaker/raw/$VERSION/ebookmaker/parsers/tidy.conf

0 comments on commit 0729c41

Please sign in to comment.