Remove mention of PHP 7.4 #1383
Conversation
Per the 202409 changelog, the next release will not support PHP 7.4. This PR removes any mention of PHP 7.4. Very importantly, it removes the PHP 7.4 CI so we can rely on the updated type system in PHP 8.1 (e.g. `mixed`). Right now, adding those types makes PHP 7.4 CI unhappy.
| * RHEL / CentOS 8.x family (with PHP 8.1 upgrade) | ||
| * RHEL / CentOS 9.x family |
There was a problem hiding this comment.
Those are based on some Googling I did and I am not super confident about those...
| // PHP will not throw a TypeError if a non-boolean is passed | ||
| // into a function with a bool type. It instead coerces it into a bool. | ||
| // This is expected and there is nothing we can do about it... | ||
| // As it is unlikely to change, keeping this test around for documentation. |
There was a problem hiding this comment.
As I think this is testing a fundamental property of PHP basic types, the value of the test is very much zero and I don't think we will ever enable it. I would recommend removing it but thought I would leave this as a discussion point for reviewers in case I missed something.
There was a problem hiding this comment.
I'm fine with removing the function altogether but maybe we want to keep the comment somewhere in there for the next person who goes "wait, why aren't we testing the boolean one"?
There was a problem hiding this comment.
Sounds good, added a comment in the test about not testing the case where $default is not a boolean.
Dwang, I didn't realize we've pushed the server upgrade... 😢 Should we close this PR for now until we're ready to merge it? Or would rather we keep it (maybe as a draft) for when we're ready? |
Why don't we get this PR merge-ready and make it into a draft and then I can merge it in (with glee) when we're ready? OH, and we will want to remove this section in if (!function_exists('str_contains')) {
// str_contains() now exists in PHP8
function str_contains($haystack, $needle)
{
return (strpos($haystack, $needle) !== false);
}
} |
Co-authored-by: Casey Peel <[email protected]>
Per the 202409 changelog, the next release will not support PHP 7.4.
This PR removes any mention of PHP 7.4. Very importantly, it removes the PHP 7.4 CI so we can rely on the updated type system in PHP 8.1 (e.g.
mixed). Right now, adding those types makes PHP 7.4 CI unhappy.