Link "skip empty diffs" with "without formatting" #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpfoley
approved these changes
Feb 27, 2024
| @@ -172,6 +172,42 @@ function copyToClip(textstring) { | |||
| echo $navigation_text; | |||
| } | |||
|
|
|||
| // Load an associative array for which pages in the project have diffs. | |||
There was a problem hiding this comment.
Since we're trying to get better about this could we add
/**
* @return array<string, array<string, mixed>>
* Return an associative array indexed by page image name, where each page has an array of attributes.
*/
function load_page_diff_array(Project $project, Round $L_round, Round $R_round, bool $include_no_format = false): array
| while ([$this_val, $this_user, $is_empty_diff] = mysqli_fetch_row($res)) { | ||
| foreach ($diff_array as $this_val => $diff_record) { | ||
| $this_user = $diff_record["username"]; | ||
| $is_diff = $format == "remove" ? $diff_record["is_diff_without_formatting"] : $diff_record["is_diff"]; |
There was a problem hiding this comment.
If you wanted to be slightly cleverer you could push the ternary inside the index:
$is_diff == $diff_record[$format == "remove" ? "is_diff_without_formatting": "is_diff"];
or
$idx = $format == "remove" ? "is_diff_without_formatting": "is_diff";
$is_diff = $diff_record[$idx];
srjfoo
approved these changes
Feb 27, 2024
70ray
approved these changes
Feb 28, 2024
When users are comparing diffs without formatting they expect "skip empty diffs" to skip pages that only differ by formatting. This links the two together so that it behaves the way that expect.
cpeel
force-pushed
the
navigate-without-formatting
branch
from
04e2468 to
6b24b2c
Compare
|
Just rebased this branch and updated the sandbox. This PR is being held until until we iron out if it's going in or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users are comparing diffs without formatting they expect "skip empty diffs" to skip pages that only differ by formatting. This links the two together so that it behaves the way that expect. Task 2000.
Sandbox: https://www.pgdp.org/~cpeel/c.branch/navigate-without-formatting/