Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new message type PURCHASE_NOTIFICATION #1226

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat: new message type PURCHASE_NOTIFICATION #1226

wants to merge 2 commits into from

Conversation

EmmmaTech
Copy link
Contributor

@EmmmaTech EmmmaTech commented Aug 10, 2024 •
edited
Loading

Summary

Implements GH-1225 & relevant types from the OpenAPI spec: Message.purchase_notification & PurchaseNotification.

Since these data types are not officially documented yet, I will put this PR on draft.
(Note: I am aware that attributes specified in the OpenAPI spec are technically public for anyone to implement, however I do not feel comfortable having the PR merged now without any explicit docs outlining this feature.)

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Snipy7374
Snipy7374 reviewed Aug 11, 2024
View reviewed changes
disnake/types/message.py Outdated Show resolved Hide resolved
@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features s: waiting for api/docs Issue/PR is waiting for API support/documentation labels Aug 11, 2024
@shiftinv shiftinv linked an issue Nov 13, 2024 that may be closed by this pull request
Add PURCHASE_NOTIFICATION system message type #1225
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snipy7374 Snipy7374 Snipy7374 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
s: waiting for api/docs Issue/PR is waiting for API support/documentation t: api support Support of Discord API features t: enhancement New feature
Projects
disnake
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PURCHASE_NOTIFICATION system message type
3 participants
@EmmmaTech @Snipy7374 @shiftinv