リアクションを押して展開されたメッセージを消去する機能の追加 #24
Merged
+127
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user can use this function anytime
sevenc-nanashi
approved these changes
May 20, 2021
Huyu2239
reviewed
May 21, 2021
Huyu2239
reviewed
May 22, 2021
sevenc-nanashi
requested changes
May 23, 2021
|
使う側が |
|
#22 実装するならここらへんになりそう |
Co-authored-by: Nanashi. <[email protected]>
|
作ってみましたがどうですか |
|
なるほど |
|
思ったんだけど環境変数に絵文字って入れられるの…？ |
|
試してから聞いて欲しかったんですが、Unicodeならなんでも入れられると思います... ❯ export EMOJI_TEST="🇯🇵"
❯ echo $EMOJI_TEST
🇯🇵 |
sevenc-nanashi
approved these changes
May 25, 2021
chun37
reviewed
May 26, 2021
| *, | ||
| payload: Optional[discord.RawReactionActionEvent] = None, | ||
| reaction: Optional[discord.Reaction] = None, | ||
| user: Optional[discord.User] = None): |
There was a problem hiding this comment.
Suggested change
| user: Optional[discord.User] = None): | |
| user: Optional[discord.User] = None) -> None: |
引数に型ヒントがあって、返り値に型ヒントが無いのは何故？
There was a problem hiding this comment.
わかりにくかったところにつけてあるだけです
ライブラリの方針としてもつけてなさそうなのでいらないかなと
| # when on_reaction_add event | ||
| if str(reaction.emoji) != DELETE_REACTION_EMOJI: | ||
| return | ||
| if user.id == bot.user.id: |
There was a problem hiding this comment.
それはエラーになるだけなのでいらないと思います
Huyu2239
reviewed
May 29, 2021
1ntegrale9
approved these changes
Jun 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
リンク展開時に🗑リアクションをつけ、元メッセージの送信者とリンク送信者がリアクションをすると消せるようにしました。
メッセージリンクの引数を使って、外観を変えることなくデータを埋め込みました。
close #20