Fix calculation of auto-fill/auto-fit repetition count when container has a definite percentage size
#722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoburns
force-pushed
the
fix/auto-fill-definite-percentage
branch
from
6043567
to
c231c3d
Compare
…iner has a definite percentage size
nicoburns
force-pushed
the
fix/auto-fill-definite-percentage
branch
from
c231c3d
to
25a5f5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Previously, when computing the repetition count for auto repetitions, Taffy was only checking whether the container had a fixed pixel size or max-size. Taffy now correctly also checks for a percentage which resolves against a definite size.