Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the launch builder #2967

Merged
merged 31 commits into from
Oct 10, 2024
Merged

Simplify the launch builder #2967

merged 31 commits into from
Oct 10, 2024

Conversation

ealmloff
Copy link
Member

@ealmloff ealmloff commented Sep 16, 2024 •
edited
Loading

Stacked on #2952
Fixes #2892
Fixes #2965

@ealmloff ealmloff added breaking This is a breaking change tweak Small changes to improve experience labels Sep 16, 2024
liigo
liigo reviewed Sep 18, 2024
View reviewed changes
examples/custom_menu.rs Outdated Show resolved Hide resolved
examples/hello_world.rs Outdated Show resolved Hide resolved
examples/hello_world.rs Outdated Show resolved Hide resolved
examples/mobile_demo/src/lib.rs Outdated Show resolved Hide resolved
packages/autofmt/tests/samples/many_exprs.rsx Outdated Show resolved Hide resolved
@ealmloff ealmloff marked this pull request as ready for review September 19, 2024 17:06
@jkelleyrtp jkelleyrtp merged commit 20d146d into DioxusLabs:main Oct 10, 2024
17 checks passed
@srid srid mentioned this pull request Oct 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liigo liigo liigo left review comments

Assignees
No one assigned
Labels
breaking This is a breaking change tweak Small changes to improve experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

launch should not be in prelude and LaunchBuilder and associated configs need to be reworked
3 participants
@ealmloff @liigo @jkelleyrtp