Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dotnet8 #1031

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Dotnet8 #1031

wants to merge 16 commits into from

Conversation

andersjonsson
Copy link
Collaborator

also updated nuget packages

<TargetFrameworks>netstandard2.0;netstandard2.1;netcoreapp3.1;net5.0;net6.0</TargetFrameworks>
<TargetFrameworks>netstandard2.0;netstandard2.1;net7.0;net8.0</TargetFrameworks>
Copy link
Contributor

@thompson-tomo thompson-tomo Apr 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the benefit in removing net core 3.1, net 5/6. At the same time only marginal benefit of having net 7. I would propose we first merge in #1052

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had the time to work on this one for a while. Will probably resume work in a couple of weeks.
net core 3.1 and net 5 are already covered by targeting netstandard.
Agree about net 7 though. It's already out of support and I don't see a reason to keep it around

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the dependency graph if you want to reduce target framework I would stick with net core 3 as otherwise u would be forcing all projects < net 8 to take on a deprecated dependencies.

Copy link

@noam-amiran noam-amiran Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this works for you? we had some difficulties making this work

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When will this be merged with the already merged pr's with a new nuget package?

@akshaybheda
Copy link
Contributor

Had a question, any tentative timeline for the release?

@cime
Copy link

cime commented Sep 10, 2024

I've merged the origin/develop into @andersjonsson dotnet8 branch, and did some other changes.
Please take a look and feel free to take any changes back to this PR or I can open a new PR.

https://github.com/cime/SoapCore/tree/dotnet8

@akshaybheda30
Copy link

@andersjonsson Net 6 goes out of support in Nov, could we expect a release in oct for this?

@andersjonsson
Copy link
Collaborator Author

@andersjonsson Net 6 goes out of support in Nov, could we expect a release in oct for this?

Sorry for the lack of activity on this branch. Life...
@cime Thanks for continuing the work! Please open a new PR and I'll take a look

@andersjonsson
Copy link
Collaborator Author

I've merged origin/develop into andersjonsson/dotnet8
I removed net7 support but kept netcoreapp3.1 around, for better or worse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants