Histogram nz implementation with tests #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have implemented a flexible nz parameterisation in the form of a histogram which I needed for my work. It is inside redshift.py and is fully vectorised so it can take in an array of redshifts, just like the other nzs provided. The input parameters are an array containing bin heights and another one containing bin edges, mirroring the numpy.histogram() implementation.
I have also added some tests, to a newly created file in tests called test_redshift.py as there wasn't one already. These just check the normalisation and that area under the nz is correct.
Let me know your thoughts!