Strategy update to support password / yubikey #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated details to say rails 4 and information on how to configure for strong parameters in rails 4 lib/devise_yubikey_database_authenticatable/strategy.rb When using yubikey OR (not AND) a password, needed to remove the resource = valid_password? and also change the resource.valid_password?(password) after validate(resource) since the password may be blank if using the Yubikey only for auth Signed-off-by: David M. Zendzian <[email protected]>
… and yubiotp Signed-off-by: David M. Zendzian @ <[email protected]>
Signed-off-by: David M. Zendzian @ rtwap <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had problems getting yubikey working on my rails 4 projects.
Changed the strategy to handle password or yubikey and it seems to work fine with rails 4+.