-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github actions #1118
Add github actions #1118
Conversation
@DerouineauNicolas can you also review this PR please? |
Looks good to me ! Good job ! |
Thanks!
For the tests, I would like remove the `cassettes` and `data` subfolders before running the tests, run one test to generate the cassettes and then run the tests for the matrix of OS and python versions with the cached cassettes (so the websites are not called 15 times).
Any idea how to do that?
…On 8 June 2024 10:20:31 GMT+01:00, DerouineauNicolas ***@***.***> wrote:
Looks good to me ! Good job !
--
Reply to this email directly or view it on GitHub:
#1118 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
I'm not sure this is a good idea to call the external APIs in the CI. I would leaves the cassettes to catch any requests, but maybe I didn't understand the problematic correctly. |
My idea was to run automatic test every month, with empty cassettes, so we make sure that the API are still working. So maybe writing another test to run every month on a single OS-python-version and with empty cassettes would be OK. |
For python versions <= 3.9, it seems that the cassettes with a gzipped content cannot be decompressed. |
From my perspective, the simpliest way to disable gzip compression would be to regenerate the cassetes with the option decode_compressed_response=True (https://vcrpy.readthedocs.io/en/latest/advanced.html#decode-compressed-response) |
Thanks I'll try that
…On 14 June 2024 11:07:25 GMT+01:00, DerouineauNicolas ***@***.***> wrote:
From my perspective, the simpliest way to disable gzip compression would be to regenerate the cassetes with the option decode_compressed_response=True (https://vcrpy.readthedocs.io/en/latest/advanced.html#decode-compressed-response)
--
Reply to this email directly or view it on GitHub:
#1118 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
all the tests are passing except for one in version py312 which is affected by #1126 . |
I wrote 2 files: