Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Provider for opensubtitles.com #1067

Merged
merged 2 commits into from
May 9, 2024
Merged

Add Provider for opensubtitles.com #1067

merged 2 commits into from
May 9, 2024

Conversation

getzze
Copy link
Collaborator

@getzze getzze commented Apr 30, 2024

Closes #1063

Please test with the develop branch.

ptrcnull
ptrcnull reviewed Apr 30, 2024
View reviewed changes
subliminal/extensions.py Outdated Show resolved Hide resolved
@getzze
Copy link
Collaborator Author

getzze commented Apr 30, 2024

I had understood from the discussion in #1063 that the old API was not available anymore. It's great if it can be repaired.

I will review #1068 when I have time, thanks!

@getzze getzze mentioned this pull request May 2, 2024
Closed
@RaXorX
Copy link

RaXorX commented May 4, 2024

Tested #1068 which worked totally fine.

@getzze getzze force-pushed the opensubtitles_com branch from 1739836 to 7b2ea37 Compare May 6, 2024 12:14
@ptrcnull ptrcnull self-requested a review May 6, 2024 12:39
@ptrcnull
Copy link
Collaborator

ptrcnull commented May 9, 2024

personal nitpick: squashing the commits, leaving only add Provider for OpenSubtitles.Com and add api key to omdb and clean tvdb

@getzze getzze force-pushed the opensubtitles_com branch from 9c525a0 to 409f2df Compare May 9, 2024 21:47
@getzze
Copy link
Collaborator Author

getzze commented May 9, 2024

Thanks for reviewing!
Note for the future, CachedSession from requests_cache is used as a default (call OpenSubtitlesComProvider(cached=False) to disable) but it is not tested as it clashes with vcr.

@getzze getzze merged commit aa04b97 into Diaoul:develop May 9, 2024
@getzze getzze mentioned this pull request May 14, 2024
Merged
@getzze getzze deleted the opensubtitles_com branch July 6, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptrcnull ptrcnull ptrcnull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@getzze @RaXorX @ptrcnull