Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing backlight detection in unit test test_detect_grid_and_do_gridscan() #671

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Nov 22, 2024

Fix for #653 as previous fix #665 was not reliable

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.31%. Comparing base (89e436f) to head (dc26d9e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #671   +/-   ##
=======================================
  Coverage   85.31%   85.31%           
=======================================
  Files         101      101           
  Lines        6726     6726           
=======================================
  Hits         5738     5738           
  Misses        988      988           
Components Coverage Δ
i24 SSX 69.57% <ø> (ø)
hyperion 96.77% <ø> (ø)
other 95.12% <ø> (ø)
---- 🚨 Try these New Features:

Copy link
Contributor

@dperl-dls dperl-dls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, why not

@rtuck99 rtuck99 merged commit 5f9203d into main Nov 22, 2024
22 checks passed
@rtuck99 rtuck99 deleted the fix_backlight_unit_test branch November 22, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants