-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MX Bluesky 651 fix energy changes #918
Conversation
602459f
to
7518e67
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #918 +/- ##
=======================================
Coverage 96.04% 96.05%
=======================================
Files 136 136
Lines 5645 5653 +8
=======================================
+ Hits 5422 5430 +8
Misses 223 223 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This may change with some of my suggestions on the mx-bluesky
side but given the current structure this is good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
a0cab60
to
eb47b4d
Compare
Remove vfm lateral lookup table as it was constant anyway Add waits for various motions that can't be parallelised
eb47b4d
to
24617fb
Compare
* Energy-related hotfixes from beamline testing 2024-11-12 * Add vfm yaw and lat changes on mirror stripe change Remove vfm lateral lookup table as it was constant anyway Add waits for various motions that can't be parallelised * Changes in response to PR comments * Move dcm offset to the undulator_dcm instead of in the device plan
Dodal changes for DiamondLightSource/mx-bluesky#651
See MX-bluesky PR DiamondLightSource/mx-bluesky#676
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}