Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #100

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Fix CI #100

merged 5 commits into from
Jan 9, 2024

Conversation

abigailalexander
Copy link
Collaborator

Python 3.12 was causing various github actions to fail, due to deprecation of distutils. I have pinned python versions to 3.11 where necessary, and also removed the pytest config that treats warnings as errors. I will also open an issue for this issues to be handled in the longer term.

Copy link
Contributor

@AlexanderWells-diamond AlexanderWells-diamond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please raise the issue now, so that you can add a comment to all relevant places quoting the issue number.

@abigailalexander
Copy link
Collaborator Author

Raised issue #101

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a8c46e) 94.15% compared to head (5d20f2c) 94.15%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   94.15%   94.15%           
=======================================
  Files          10       10           
  Lines         856      856           
=======================================
  Hits          806      806           
  Misses         50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlexanderWells-diamond AlexanderWells-diamond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@abigailalexander abigailalexander merged commit 710027d into main Jan 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants