Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard 0 byte placeholder object when listing #48

Merged
merged 8 commits into from
Jul 15, 2024

Conversation

Akopti8
Copy link
Collaborator

@Akopti8 Akopti8 commented Jul 2, 2024

Skip zero-byte objects that match a common prefix with a trailing slash. These objects are created as placeholders when users create directories directly within the AWS S3 console and cause errors.

@Akopti8 Akopti8 marked this pull request as ready for review July 2, 2024 17:41
@Akopti8 Akopti8 requested a review from ShaneMPutnam July 2, 2024 17:41
Copy link
Member

@ShaneMPutnam ShaneMPutnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment, looks good otherwise

main.go Show resolved Hide resolved
Copy link
Member

@ShaneMPutnam ShaneMPutnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the following change to improve consistency of when the permissions are checked: b22b07f

@ShaneMPutnam ShaneMPutnam merged commit 7ad3820 into main Jul 15, 2024
1 check passed
@ShaneMPutnam ShaneMPutnam deleted the error-discard-placeholder-obj branch July 15, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants