Chore/#71 refactor tests using msw #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add msw to mock backend and avoid mocking the service. Simplify some test cases by checking for only the needed elements. Add error handling to the data service. Addresses #71
Use msw to add group data service tests and remove the ignore comment.a Addresses #71
Move test setup files out of source folder to avoid needing dependencies instead of dev dependencies when compiling typescript. Addresses #71
8 tasks
duke-b
reviewed
Nov 20, 2023
backstage-plugin/plugins/open-dora/src/services/GroupDataService.test.ts
Outdated
Show resolved
Hide resolved
So that we can check for the exact decimal used from the response. Should help make the test a bit clearer. Addresses #71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added msw to avoid mocking services and test UI closer to real usage.
Adds tests for GroupDataService so that we have full coverage.
Issue
This PR addresses issue #71.
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.