Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Drive Interface/Stub #9

Closed
wants to merge 3 commits into from
Closed

Conversation

BrownGenius
Copy link
Contributor

This is an example of what I was thinking for the drive train interface, stub implementation, and placeholders for swerve and tank drive. Please review and commemd.

Copy link
Contributor

@CodeSalvageON CodeSalvageON left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most (if not all) of it works!

@BrownGenius BrownGenius marked this pull request as ready for review January 13, 2024 20:02
Copy link
Contributor

@StewardHail3433 StewardHail3433 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this as a simple Drive Interface. Everything makes sense for future implementation. Do we want to leave this open for Tank and Swerve?

@StewardHail3433 StewardHail3433 dismissed their stale review January 15, 2024 03:14

Incorrect information

@BrownGenius
Copy link
Contributor Author

We will abandon multi-robot config support at the moment, so the drive interface should be closer to what we want for the actual swerve comp bot.

@BrownGenius BrownGenius deleted the driveSubsystemInterface branch January 19, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants