Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup intake interface #6

Merged
merged 9 commits into from
Jan 20, 2024
Merged

Setup intake interface #6

merged 9 commits into from
Jan 20, 2024

Conversation

StewardHail3433
Copy link
Contributor

No description provided.

Copy link
Contributor

@BrownGenius BrownGenius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the shooter comments, for the intake the basic control interface is:

  • Intake
    • Off - No/All Bumper Pressed
    • In - Right Bumper Pressed
    • Out - Left Bumper Pressed

A single command might be useful, similar to the shooter. E.g. setSpeed(double speed) [-1.0 .. 1.0] might be sufficient to implement in (+ values), out (- values), off (0).

@ParkerMeyers
Copy link

Please use draft PRs if the PR is not ready to merge.

Also, please merge the latest changes in & make sure the build is not failing

@ParkerMeyers ParkerMeyers marked this pull request as draft January 18, 2024 14:51
@CarterBiscuit CarterBiscuit marked this pull request as ready for review January 20, 2024 19:18
Copy link
Contributor

@BrownGenius BrownGenius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@BrownGenius BrownGenius merged commit f58f702 into main Jan 20, 2024
2 checks passed
@BrownGenius BrownGenius deleted the setup-intake-interface branch January 20, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants