Shooter Subsystem Cleanup #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrownGenius
added a commit
that referenced
this pull request
Apr 4, 2024
* Arm Trapezoid Motion Profile * Fixed compilation error * Cleaned up Arm API. Removed redundant ArmIO input values * Cleaned up Arm Subsystem Interface * Fixed reported currentDraw in ArmIOStub * Updated camera location based on measurements * Add error to vision camera simulation * Add 2d based pose estimate * Adjust arm trapezoid profile constraints based on testing * Add vision pose estimates to drivetrain * Update gyro using vision * spotlessApply * "Drive to Amp" command (test) * Shooter Subsystem Cleanup (#104) * Added arm backlash compensation code (#103) * Added 3 degree backlash compensation * add side vision cameras (#106) * Add left/right vision cameras * Only run arm command when driver assist is actuating stick * Improved 4-Note (Center) v2.0 C231 * Added 4-Note (Center) v2.1 C231 M5 * Update TestShooteAngle command to only update subsystem if the shuffleboard value has changed * Fixed P to 8 Center Sweep Routine * Fixed "Drive to Amp" command * Updated "Drive to Amp" to correct yaw and decrease acceleration * Add support for a second intake sensor (#107) * Add support for a second intake sensor * Made changes to drive controls * Fixed drive to amp driver control * Do not control arm for prepare to score when in amp mode * Avoid using arm at all when aiming for amp * Split rightBumper to 4 separate triggers * Split ParallelCommands into separate scheduled commands * Set default scoring mode to vision-based * Recalibrate shooter camera location --------- Co-authored-by: joshuman <[email protected]> * Update LedSystem.java changed color from hot pink to deep pink * Re-Measured left/right camera locations * Remove Arm Backlash Compensation * Updated getArmAngleFromDistance() to use 2nd-degree polynomial and latest distance/angle calibration data * Fixed typo * Practice Tweaks --------- Co-authored-by: Maciej Wiczynski <[email protected]> Co-authored-by: joshuman <[email protected]> Co-authored-by: Adi Prajapati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.