-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] #107-랭킹뷰 수정 (쇼케이스용) #109
Conversation
- 사용자의 언어 설정 기준에서의 사전순으로 정렬
- 진행자보다 위(isAboveHost)는 first효과 - 진행자는 last효과
- 순위대신 진행자 기준 승패여부에 따라 win/lose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
새벽에 고많고많~~
이전 pr 문제 해결 후 붙입시다
RankRow(player: player, | ||
rank: index + 1, | ||
isWin: isWin, // 호스트 보다 위인 사람은 first 효과 | ||
isHost: player.isHost) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
승리조건 로직 확인!
} else if isHost { | ||
return "-" | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
진행자의 경우 '-' 한글자만 있어서 왼쪽으로 좀 치우쳐지는데
디자이너한테 한번 물어봅죠
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋습니다!
👀 연관 이슈
resolved: #107
🛏️ 요약
🎁 작업 내용
1. isHost 속성을 기준으로 UI 반영
2. 순위 명칭 변경
진행자를 이겼는지 혹은 졌는지가 더 중요하다고 판단해서 함 바꿔봤는데 어떠신가요?
📱 작업 스크린샷 (선택)
🎾 공유사항 (선택)
격려의 한 마디 (선택)
외마디 비명 (선택)