-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] #106-Default Player 설정 (쇼케이스용) #108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 사용자의 언어 설정 기준에서의 사전순으로 정렬
3 tasks
HyunJaeyeon
changed the title
[Feat] #106-showcase default player
[Feat] #106-Default Player 설정 (쇼케이스용)
Nov 30, 2024
mosiccan
requested changes
Dec 1, 2024
PepperoniV2/Presentation/GameSetting/PlayerSetting/PlayerSettingView.swift
Show resolved
Hide resolved
mosiccan
approved these changes
Dec 1, 2024
Comment on lines
+47
to
+51
if player.isHost { | ||
tempPlayers[index].nickname = "진행자" | ||
} else { | ||
tempPlayers[index].nickname = "도전자\(player.turn - 1)" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인요잉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀 연관 이슈
resolved: #106
🛏️ 요약
🎁 작업 내용
1. isHost 속성 추가
2. 뷰와 뷰모델에 반영
📱 작업 스크린샷 (선택)
ScreenRecording_12-01-2024.04-30-53_1.MP4
🎾 공유사항 (선택)
showcase
로 설정하였습니다.