Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: 왼쪽손 손목 회전시 소리가 나지 않는 현상 해결 #55

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

MartyTheGout
Copy link
Collaborator

이슈

#54

작업 사항

  • 왼쪽 회전시 소리가 나지 않는 현상을 chirality 를 함수내에 반영하여, 어느쪽 손목엔티티의 스페이셜오디오에서 오디오를 재생해야하는지 설정하도록 변경.

고민 or 참고 사항 (선택)

스크린샷 (선택)

@MartyTheGout MartyTheGout requested a review from jsangyun November 9, 2024 07:01
@MartyTheGout MartyTheGout self-assigned this Nov 9, 2024
Copy link
Collaborator

@jsangyun jsangyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

알찬 하루를 보내시는 마르띠 리스펙 👍

Comment on lines -128 to +130
try? await playSpatialAudio(rightGuideRing, audioInfo: AudioFindHelper.handRotationThreeTimes)
try? await playSpatialAudio(guideRing, audioInfo: AudioFindHelper.handRotationThreeTimes)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오디오 재생하는 부분도 try?문으로 간단하게 적는 것도 좋지만 에러가 발생했을 때 알 수 있도록 do catch를 활용해보는 것도 좋을 것 같아요 😄

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다음 PR때에 반영하여서 수정하겠습니다! 감사해요 위니

@MartyTheGout MartyTheGout merged commit fefaa89 into main Nov 9, 2024
@MartyTheGout MartyTheGout deleted the bug/#54-NoSoundAtLeft branch November 9, 2024 16:23
Copy link
Collaborator

@daminoworld daminoworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

버그 수정 수고하셨습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants