fix: add check prev element

DevExpress · Sep 27, 2024 · 72f2f88 · 72f2f88
1 parent 4c9f03b
commit 72f2f88
Show file tree

Hide file tree

Showing 4 changed files with 40 additions and 0 deletions.
diff --git a/src/client/automation/playback/move/event-sequence/base.js b/src/client/automation/playback/move/event-sequence/base.js
@@ -29,6 +29,15 @@ export default class MoveEventSequenceBase {
  }
 
  run (currentElement, prevElement, options, dragElement, dragDataStore) {
+
+ const prevElementInDocument = prevElement && domUtils.isElementInDocument(prevElement);
+
+ const prevElementInRemovedIframe = prevElement && domUtils.isElementInIframe(prevElement) &&
+ !domUtils.getIframeByElement(prevElement);
+
+ if (!prevElementInDocument || prevElementInRemovedIframe)
+ prevElement = null;
+
  const elementChanged = currentElement !== prevElement;
  const commonAncestor = elementChanged ? domUtils.getCommonAncestor(currentElement, prevElement) : null;
 

diff --git a/test/functional/fixtures/regression/gh-8264/pages/index.html b/test/functional/fixtures/regression/gh-8264/pages/index.html
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+ <meta charset="UTF-8">
+</head>
+<body>
+ <a href="#" id="link">Click me to remove</a>
+ <button id="btn">Button</button>
+
+ <script>
+ document.getElementById('link').addEventListener('click', function(event) {
+ event.preventDefault(); // Prevent the default link behavior
+ this.remove(); // Remove the link element from the page
+ });
+ </script>
+</body>
+</html>
diff --git a/test/functional/fixtures/regression/gh-8264/test.js b/test/functional/fixtures/regression/gh-8264/test.js
@@ -0,0 +1,5 @@
+describe('[Regression](GH-8264)', function () {
+ it('Test should not fails with Uncaught object error on leaveElement when the prevElement is removed from the DOM', function () {
+ return runTests('testcafe-fixtures/index.js', 'Callsite Issue', { only: 'chrome' });
+ });
+});
diff --git a/test/functional/fixtures/regression/gh-8264/testcafe-fixtures/index.js b/test/functional/fixtures/regression/gh-8264/testcafe-fixtures/index.js
@@ -0,0 +1,9 @@
+
+fixture('GH-8264 - Callsite Issue')
+ .page`http://localhost:3000/fixtures/regression/gh-8264/pages/index.html`;
+
+test('Callsite Issue', async t => {
+ await t
+ .click('#link')
+ .click('#btn');
+});