Make session request events asynchronous (#2795)

DevExpress · Sep 29, 2022 · 2d339a8 · 2d339a8
1 parent 0aa7cdb
commit 2d339a8
Show file tree

Hide file tree

Showing 4 changed files with 129 additions and 142 deletions.
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "testcafe-hammerhead",
   "description": "A powerful web-proxy used as a core for the TestCafe testing framework (https://github.com/DevExpress/testcafe).",
-  "version": "24.7.4",
+  "version": "25.0.0",
   "homepage": "https://github.com/DevExpress/testcafe-hammerhead",
   "bugs": {
     "url": "https://github.com/DevExpress/testcafe-hammerhead/issues"

diff --git a/src/session/index.ts b/src/session/index.ts
@@ -297,7 +297,7 @@ export default abstract class Session extends EventEmitter {
         return !!this.requestEventListeners.size;
     }
 
-    addRequestEventListeners (rule: RequestFilterRule, listeners: RequestEventListeners, errorHandler: (event: RequestEventListenerError) => void): void {
+    async addRequestEventListeners (rule: RequestFilterRule, listeners: RequestEventListeners, errorHandler: (event: RequestEventListenerError) => void): Promise<void> {
         const listenersData = {
             listeners,
             errorHandler,
@@ -307,7 +307,7 @@ export default abstract class Session extends EventEmitter {
         this.requestEventListeners.set(rule.id, listenersData);
     }
 
-    removeRequestEventListeners (rule: RequestFilterRule): void {
+    async removeRequestEventListeners (rule: RequestFilterRule): Promise<void> {
         this.requestEventListeners.delete(rule.id);
     }