WIP: Use true imported union / enum types instead of explicit (string) acceptable values React / Vue #28129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f explicit acceptable values (53), known conflict (error TS2300: Duplicate identifier 'LocalizationTypes')
…explicit acceptable values (71), object instead of array / string
…0: Duplicate identifier 'LocalizationTypes') (21)
… in generators, acceptable values are collapsed to object (71)
… support in generators, acceptable values are collapsed to object (71)" This reverts commit 3ab12f1.
mpreyskurantov
force-pushed
the
24_2-imd-enums-types-dev
branch
from
7368d7c to
bb53ef9
Compare
This reverts commit 2de3621.
mpreyskurantov
commented
Oct 8, 2024
| rtlEnabled: Boolean, | ||
| stylingMode: String, | ||
| stylingMode: Object as PropType<ButtonStyle>, |
There was a problem hiding this comment.
Suggested change
| stylingMode: Object as PropType<ButtonStyle>, | |
| stylingMode: [Object, String] as PropType<ButtonStyle>, |
Suggested change
| stylingMode: Object as PropType<ButtonStyle>, | |
| stylingMode: ['text', 'outlined', 'contained'] as PropType<ButtonStyle>, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReOpened at #28291