fix: selectbox keyboard navigation is broken in React Strict Mode (T1230720) #28021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VasilyStrelyaev
force-pushed
the
react-test-restore-focus
branch
from
1046fec to
3927d53
Compare
dxvladislavvolkov
approved these changes
Sep 10, 2024
| @@ -1,7 +1,7 @@ | |||
|
|
|||
| module.exports = { | |||
| src: './src/**/*.{ts,tsx}', | |||
| testSrc: './src/**/__tests__/*.*', | |||
| testSrc: './src/**/__tests__/**/*.*', | |||
There was a problem hiding this comment.
Why regex here is changed? Can't find tests in your pr, that satisfy your regex version, but don't satisfy previous one
There was a problem hiding this comment.
It's a fix for an issue that appeared when I introduced a new test subfolder - the test was included in npm package:
It turned out only files directly in __tests__ directories were removed from the package. When I created a deeper-lying test file, the removal logic did not work for it.
ivanblinov2k17
approved these changes
Sep 12, 2024
VasilyStrelyaev
added a commit
to VasilyStrelyaev/DevExtreme
that referenced
this pull request
Sep 12, 2024
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.