Chat: Add basic styles by layout, mixins and variables #27982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marker-dao
force-pushed
the
24_2_chat_design
branch
2 times, most recently
from
53ab7e3 to
eaa65fe
Compare
EugeniyKiyashko
requested changes
Sep 3, 2024
packages/devextreme-scss/scss/widgets/base/chat/layout/chat-avatar/_index.scss
Show resolved
Hide resolved
packages/devextreme-scss/scss/widgets/base/chat/layout/chat-avatar/_index.scss
Outdated
Show resolved
Hide resolved
packages/devextreme-scss/scss/widgets/base/chat/layout/chat-header/_index.scss
Outdated
Show resolved
Hide resolved
packages/devextreme-scss/scss/widgets/base/chat/layout/chat-messagebox/_index.scss
Outdated
Show resolved
Hide resolved
packages/devextreme-scss/scss/widgets/base/chat/layout/chat-messagebox/_index.scss
Outdated
Show resolved
Hide resolved
packages/devextreme-scss/scss/widgets/base/chat/layout/chat-messagebox/_index.scss
Show resolved
Hide resolved
packages/devextreme-scss/scss/widgets/material/chat/_colors.scss
Outdated
Show resolved
Hide resolved
packages/devextreme-scss/scss/widgets/base/chat/layout/chat-messagebubble/_mixins.scss
Show resolved
Hide resolved
|
Kindly make PR's title more informative |
marker-dao
changed the title
marker-dao
force-pushed
the
24_2_chat_design
branch
from
b5bbab3 to
b220247
Compare
EugeniyKiyashko
requested changes
Sep 4, 2024
packages/devextreme-scss/scss/widgets/base/chat/layout/chat/_mixins.scss
Show resolved
Hide resolved
packages/devextreme-scss/scss/widgets/base/chat/layout/chat-messagebubble/_index.scss
Outdated
Show resolved
Hide resolved
packages/devextreme-scss/scss/widgets/base/chat/layout/chat-messagebubble/_index.scss
Show resolved
Hide resolved
packages/devextreme-scss/scss/widgets/base/chat/layout/chat-avatar/_index.scss
Show resolved
Hide resolved
packages/devextreme-scss/scss/widgets/base/chat/layout/chat-messagebox/_mixins.scss
Outdated
Show resolved
Hide resolved
|
|
||
| .dx-chat-message-box-text-area { | ||
| &.dx-textarea.dx-texteditor { | ||
| min-height: $textarea-min-height; |
There was a problem hiding this comment.
Issues:
- The label is not center-aligned in Fluent
2. Height of input is 53px, not 48px
Currently, we are trying to set custom heights for text areas in themes that differ from the standard editor heights by ±2px. I don't understand why this is necessary, instead of adjusting the design of the text area to make it look like a 'textbox.'
@Shuvaevmedia
packages/devextreme-scss/scss/widgets/base/chat/layout/chat-messagebox/_mixins.scss
Outdated
Show resolved
Hide resolved
packages/devextreme-scss/scss/widgets/base/chat/layout/chat-messagebox/_mixins.scss
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets/chatParts/messageBox.tests.js
Outdated
Show resolved
Hide resolved
|
#27982 (comment) |
marker-dao
force-pushed
the
24_2_chat_design
branch
from
2f782e2 to
4a191a1
Compare
ksercs
reviewed
Sep 5, 2024
| @@ -53,14 +53,14 @@ class Chat extends Widget<Properties> { | |||
|
|
|||
| super._initMarkup(); | |||
|
|
|||
| this._renderMessageBox(); | |||
There was a problem hiding this comment.
I think that previous rendering order was correct.
If there is some issue with scrollable dimensions calculations, let's just update it after list rendering. But i don't like we try to hack rendering order. At least it will lead to difficulties when we start rendering header
There was a problem hiding this comment.
We decided to bring this issue up for discussion and will fix the rendering order in a separate task if needed
packages/devextreme-scss/scss/widgets/base/chat/layout/chat-messagebox/_index.scss
Show resolved
Hide resolved
packages/devextreme-scss/scss/widgets/base/chat/layout/chat-messagebox/_mixins.scss
Outdated
Show resolved
Hide resolved
EugeniyKiyashko
previously approved these changes
Sep 6, 2024
ksercs
previously approved these changes
Sep 6, 2024
added 21 commits
September 6, 2024 16:59
marker-dao
force-pushed
the
24_2_chat_design
branch
from
1b7e970 to
a5f9935
Compare
marker-dao
dismissed stale reviews from ksercs and EugeniyKiyashko
via
2e6b58c
ksercs
approved these changes
Sep 6, 2024
EugeniyKiyashko
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.