Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript - CustomStore onLoaded result own param type (T1197789) #26244

Merged
merged 16 commits into from
Dec 22, 2023

Conversation

mpreyskurantov
Copy link
Contributor

@mpreyskurantov mpreyskurantov commented Dec 12, 2023

Cherry-picks

Changelog:

  • Move the StoreOptions / Store types from the abstract_store.d.ts module to the store.d.ts one:
    • Change namespace for moved StoreOptions (append .Store), but keep namespace for Store, because it is a namespace itself (as a type) in a bundle.
    • Add re-exports for moved members in a previous module (for module users) and an alias for StoreOptions only (because of the changed namespace) in aliases.d.ts (for dx.all.d.ts bundle users);
    • Re-generate integration wrappers:
      • Angular now refers to a fully-specified namespace from the devextreme/bundles/dx.all bundle (instead of the devextreme/data module);
      • React now refers to an actual relative (moved) devextreme module / path devextreme/data/store (instead of the devextreme/data/abstract_store one).
  • Define the Options type aka AbstractStoreOptions (for AbstractStore added at fix return type for CustomStore.load() (T1128989) #23287) that extends moved StoreOptions with the onLoaded member.
    • Remove the excessive onLoading member with the same signature from ODataStoreOptions.
  • Define the CustomStoreOptions.onLoaded member with the correct signature.

A proposed Docs generation result:
DevExpress/devextreme-documentation#5875

@mpreyskurantov mpreyskurantov self-assigned this Dec 12, 2023
@mpreyskurantov mpreyskurantov requested review from a team as code owners December 12, 2023 07:59
@mpreyskurantov mpreyskurantov added the WIP Work in progress label Dec 12, 2023
@mpreyskurantov mpreyskurantov changed the title TypeScript - CustomStore onLoaded TypeScript - CustomStore onLoaded method result own param type (T1197789) Dec 18, 2023
@mpreyskurantov mpreyskurantov changed the title TypeScript - CustomStore onLoaded method result own param type (T1197789) TypeScript - CustomStore onLoaded result own param type (T1197789) Dec 18, 2023
@mpreyskurantov mpreyskurantov removed the WIP Work in progress label Dec 20, 2023
@mpreyskurantov mpreyskurantov merged commit 35147f4 into DevExpress:23_2 Dec 22, 2023
177 checks passed
mpreyskurantov added a commit to mpreyskurantov/DevExtreme that referenced this pull request Dec 22, 2023
@mpreyskurantov mpreyskurantov deleted the 23_2-T1197789-dts branch December 22, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants