TagBox - Fix custom item rendering after deleting equal value(T1197444) #26179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksercs
reviewed
Dec 7, 2023
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/tagBox.tests.js
Outdated
Show resolved
Hide resolved
packages/devextreme/js/ui/tag_box.js
Outdated
| @@ -1485,6 +1485,10 @@ const TagBox = SelectBox.inherit({ | |||
| return existedItems.concat(newItems); | |||
| }, | |||
|
|
|||
| _isCustomItemSelected() { | |||
There was a problem hiding this comment.
Let's think a bit more how can we rework the actual algorithm to fix the issue.
Function with name _isCustomItemSelected should not return just acceptCustomValue. Moreover, as far as i see we already have the check for acceptCustomValue in the SelectBox's valueChangeHandler. It would be great if we research why we need this code in selectBox and prepare more intuitive solution.
There was a problem hiding this comment.
fix reworked
ksercs
approved these changes
Dec 11, 2023
iBat
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.