Core: fix/ignore eslint errors

DevExpress · Oct 4, 2024 · dd3cf72 · dd3cf72
1 parent 4c3da97
commit dd3cf72
Show file tree

Hide file tree

Showing 33 changed files with 296 additions and 266 deletions.
diff --git a/packages/devextreme/js/__internal/core/m_action.ts b/packages/devextreme/js/__internal/core/m_action.ts
@@ -62,7 +62,7 @@ class Action {
     const excludeValidators = this._excludeValidators;
     const { executors } = Action;
 
-    for (const name in executors) {
+    Object.keys(executors).forEach((name) => {
       if (!excludeValidators[name]) {
         const executor = executors[name];
         executor.validate?.(e);
@@ -71,7 +71,7 @@ class Action {
           return false;
         }
       }
-    }
+    });
 
     return true;
   }
@@ -80,15 +80,16 @@ class Action {
     let result;
     const { executors } = Action;
 
-    for (const name in executors) {
+    Object.keys(executors).some((name) => {
       const executor = executors[name];
       executor.execute?.(e);
 
       if (e.handled) {
         result = e.result;
-        break;
+        return true;
       }
-    }
+      return false;
+    });
 
     return result;
   }
@@ -103,6 +104,7 @@ class Action {
 
   static unregisterExecutor(...args) {
     each(args, function () {
+      // eslint-disable-next-line @typescript-eslint/no-dynamic-delete
       delete Action.executors[this];
     });
   }

diff --git a/packages/devextreme/js/__internal/core/m_class.ts b/packages/devextreme/js/__internal/core/m_class.ts
@@ -14,26 +14,27 @@ const wrapOverridden = function (baseProto, methodName, method) {
 };
 
 const clonePrototype = function (obj) {
-  const func = function () { };
-  func.prototype = obj.prototype;
-  return new func();
+  const Func = function () { };
+  Func.prototype = obj.prototype;
+  return new Func();
 };
 
 const redefine = function (members) {
   const that = this;
   let overridden;
-  let memberName;
   let member;
 
   if (!members) {
     return that;
   }
 
-  for (memberName in members) {
+  Object.keys(members).forEach((memberName) => {
     member = members[memberName];
     overridden = typeof that.prototype[memberName] === 'function' && typeof member === 'function';
-    that.prototype[memberName] = overridden ? wrapOverridden(that.parent.prototype, memberName, member) : member;
-  }
+    that.prototype[memberName] = overridden
+      ? wrapOverridden(that.parent.prototype, memberName, member)
+      : member;
+  });
 
   return that;
 };
@@ -63,6 +64,7 @@ const include = function () {
       classObj._includedPostCtors.push(argument.postCtor);
     }
 
+    // eslint-disable-next-line no-restricted-syntax
     for (name in argument) {
       if (name === 'ctor' || name === 'postCtor' || name === 'default') {
         continue;

diff --git a/packages/devextreme/js/__internal/core/m_component_registrator.ts b/packages/devextreme/js/__internal/core/m_component_registrator.ts
@@ -3,18 +3,18 @@ import errors from '@js/core/errors';
 import $ from '@js/core/renderer';
 import { name as publicComponentName } from '@js/core/utils/public_component';
 
-const registerComponent = function (name, namespace, componentClass) {
-  if (!componentClass) {
-    componentClass = namespace;
+const registerComponent = function (name, namespace, ComponentClass) {
+  if (!ComponentClass) {
+    ComponentClass = namespace;
   } else {
-    namespace[name] = componentClass;
+    namespace[name] = ComponentClass;
   }
 
-  publicComponentName(componentClass, name);
-  callbacks.fire(name, componentClass);
+  publicComponentName(ComponentClass, name);
+  callbacks.fire(name, ComponentClass);
 };
 
-const registerRendererComponent = function (name, componentClass) {
+const registerRendererComponent = function (name, ComponentClass) {
   $.fn[name] = function (options) {
     const isMemberInvoke = typeof options === 'string';
     let result;
@@ -24,7 +24,7 @@ const registerRendererComponent = function (name, componentClass) {
       const memberArgs = [].slice.call(arguments).slice(1);
 
       this.each(function () {
-        const instance = componentClass.getInstance(this);
+        const instance = ComponentClass.getInstance(this);
 
         if (!instance) {
           throw errors.Error('E0009', name);
@@ -39,11 +39,12 @@ const registerRendererComponent = function (name, componentClass) {
       });
     } else {
       this.each(function () {
-        const instance = componentClass.getInstance(this);
+        const instance = ComponentClass.getInstance(this);
         if (instance) {
           instance.option(options);
         } else {
-          new componentClass(this, options);
+          // eslint-disable-next-line no-new
+          new ComponentClass(this, options);
         }
       });
 

diff --git a/packages/devextreme/js/__internal/core/m_config.ts b/packages/devextreme/js/__internal/core/m_config.ts
@@ -60,8 +60,7 @@ const config = {
 const normalizeToJSONString = (optionsString) => optionsString
   .replace(/'/g, '"') // replace all ' to "
   .replace(/,\s*([\]}])/g, '$1') // remove trailing commas
-  .replace(/([{,])\s*([^":\s]+)\s*:/g, '$1"$2":') // add quotes for unquoted keys
-;
+  .replace(/([{,])\s*([^":\s]+)\s*:/g, '$1"$2":'); // add quotes for unquoted keys
 
 const deprecatedFields = ['decimalSeparator', 'thousandsSeparator'];
 

diff --git a/packages/devextreme/js/__internal/core/m_devices.ts b/packages/devextreme/js/__internal/core/m_devices.ts
@@ -98,6 +98,7 @@ const UA_PARSERS = {
     const isPhone = /mobile/i.test(userAgent);
     const matches = userAgent.match(/android (\d+)\.?(\d+)?\.?(\d+)?/i);
     const version = matches ? [parseInt(matches[1], 10), parseInt(matches[2] || 0, 10), parseInt(matches[3] || 0, 10)] : [];
+    // eslint-disable-next-line @typescript-eslint/naming-convention
     const worseThan4_4 = version.length > 1 && (version[0] < 4 || version[0] === 4 && version[1] < 4);
     const grade = worseThan4_4 ? 'B' : 'A';
 

diff --git a/packages/devextreme/js/__internal/core/m_element_data.ts b/packages/devextreme/js/__internal/core/m_element_data.ts
@@ -61,6 +61,7 @@ setDataStrategy({
     } else {
       const elementData = dataMap.get(element);
       if (elementData) {
+        // eslint-disable-next-line @typescript-eslint/no-dynamic-delete
         delete elementData[key];
       }
     }

diff --git a/packages/devextreme/js/__internal/core/m_inferno_renderer.ts b/packages/devextreme/js/__internal/core/m_inferno_renderer.ts
@@ -3,6 +3,7 @@ import domAdapter from '@js/core/dom_adapter';
 import { cleanDataRecursive } from '@js/core/element_data';
 import injector from '@js/core/utils/dependency_injector';
 import { render } from 'inferno';
+// eslint-disable-next-line import/no-extraneous-dependencies
 import { createElement } from 'inferno-create-element';
 
 const remove = (element) => {

diff --git a/packages/devextreme/js/__internal/core/m_postponed_operations.ts b/packages/devextreme/js/__internal/core/m_postponed_operations.ts
@@ -22,7 +22,7 @@ export class PostponedOperations {
   }
 
   callPostponedOperations() {
-    for (const key in this._postponedOperations) {
+    Object.keys(this._postponedOperations).forEach((key) => {
       const operation = this._postponedOperations[key];
 
       if (isDefined(operation)) {
@@ -32,7 +32,7 @@ export class PostponedOperations {
           operation.fn().done(operation.completePromise.resolve);
         }
       }
-    }
+    });
     this._postponedOperations = {};
   }
 }