Skip to content

Commit

Permalink
Fix list skips records on adjacent data pages when the Push API is us…
Browse files Browse the repository at this point in the history
…ed to remove records (T1250900)

+WIP
  • Loading branch information
GoodDayForSurf committed Sep 25, 2024
1 parent c5b30fe commit cfc61c2
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
1 change: 1 addition & 0 deletions packages/devextreme-angular/src/core/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@ export abstract class DxComponent implements OnChanges, OnInit, DoCheck, AfterCo
this._updateTemplates();
this.instance.endUpdate();
this.recreatedNestedComponents = [];
this.instance._beforeInit?.();
}

ngAfterViewChecked(): void {
Expand Down
6 changes: 3 additions & 3 deletions packages/devextreme-vue/src/core/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -312,14 +312,13 @@ function initDxComponent() {
return defineComponent({
extends: initBaseComponent(),
methods: {
/* $_getExtraIntegrationOptions(): object {
$_getExtraIntegrationOptions(): object {
return {
onInitializing() {
(this as any).beginUpdate();
(this as any).endUpdate();
},
};
},*/
},

$_processChildren(children: VNode[]): void {
children.forEach((childNode: VNode) => {
Expand All @@ -336,6 +335,7 @@ function initDxComponent() {

this.$_createWidget(this.$el);
thisComponent.$_instance.endUpdate();
thisComponent.$_instance._beforeInit?.();
restoreNodes(this.$el, nodes);

if (this.$slots && this.$slots.default) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,17 @@ export default CollectionWidget.inherit({
}
};

this._dataController?.on('customizeStoreLoadOptions', this._customizeStoreLoadOptions);
this._beforeInit();
},

reload() {
this._correctionIndex = 0;
},

_beforeInit() {
this._dataController?.on('customizeStoreLoadOptions', this._customizeStoreLoadOptions);
},

_init() {
this.callBase();
this._refreshItemsCache();
Expand Down

0 comments on commit cfc61c2

Please sign in to comment.